[PATCH] D13432: cmake: Avoid leading space in LLVM_DEFINITIONS.

John Brawn via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 6 03:58:53 PDT 2015


john.brawn added a subscriber: john.brawn.
john.brawn added a comment.

In http://reviews.llvm.org/D13432#259652, @chapuni wrote:

> I guess it would work. By the way, what is your issue?


It appears that when there's a leading space in LLVM_DEFINITIONS that

  add_definitions(${LLVM_DEFINITIONS}

works as expected, but

  target_compile_definitions(example PUBLIC ${LLVM_DEFINITIONS})

gets you -D -DWHATEVER. Removing the leading space in LLVM_DEFINITIONS seems to make target_compile_definitions behave as expected.


http://reviews.llvm.org/D13432





More information about the llvm-commits mailing list