[PATCH] D13427: RFC: faster isa<IntrinsicInst> (bugged tests?)

[Sean Silva via llvm-commits]

The inconsistency is clearly troubling and is worth fixing. This review may
have gotten off to a bad start by focusing on the performance aspect. Any
time correctness and performance get mixed into the same discussion this
sort of thing tends to happen.

(also, I don't think anybody is really advocating the use of string
comparisons)

@vedant: do you know if it is important for compatibility for us to use
strings in the tests Fiona pointed out? Can we just switch those tests to
use a real intrinsic?

-- Sean Silva

On Mon, Oct 5, 2015 at 5:40 PM, escha <escha at apple.com> wrote:

> escha abandoned this revision.
> escha added a comment.
>
> Since people don't seem to be particularly interested in fixing
> broken+inconsistent behavior and believe performing string comparisons is a
> reasonable and performant way of checking class membership, I'm not going
> to bother with this.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D13427
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151005/dce95bd2/attachment.html>