[PATCH] D13449: [WinEH] Recognize CoreCLR personality function

[Reid Kleckner via llvm-commits]

rnk added a comment.

In http://reviews.llvm.org/D13449#260132, @JosephTremoulet wrote:

> I'm not wedded to the name `isWinCFIPersonality` if people are opposed to conflating WinCFI with use of these handlers.  I just thought MSVC didn't make sense with CLR included.  I thought about `isWinEHPersonality` and variants, but since (a) we don't use these on e.g. MinGW and (b) CoreCLR will likely use these on non-Windows, tying it to WinCFI seemed most apt.


I agree, MSVC doesn't make sense. I don't think "CFI" makes sense, since that's mainly about call frame information, which x86 Windows doesn't even have. My first thought was that it should be `isWinEHPersonality`. I rationalized that the CoreCLR personality comes from Windows even if it works elsewhere, and `__gxx_personality_seh0` comes from Unix even though it runs on Windows.

David likes `isFuncletEHPersonality`, and I think that's a winner for me. Does that sound like a reasonable shade of chartreuse for the bikeshed? :)


http://reviews.llvm.org/D13449