[llvm] r249351 - Remove AutoFDO profile handling for GCC's LIPO. NFC.

Diego Novillo via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 5 14:08:06 PDT 2015


Author: dnovillo
Date: Mon Oct  5 16:08:05 2015
New Revision: 249351

URL: http://llvm.org/viewvc/llvm-project?rev=249351&view=rev
Log:
Remove AutoFDO profile handling for GCC's LIPO. NFC.

Given the work we are doing on ThinLTO, we will never need to support
module groups and working sets in GCC's implementation of LIPO. These
are currently dead code, and will continue to be so.

Modified:
    llvm/trunk/include/llvm/ProfileData/SampleProfReader.h
    llvm/trunk/lib/ProfileData/SampleProfReader.cpp

Modified: llvm/trunk/include/llvm/ProfileData/SampleProfReader.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ProfileData/SampleProfReader.h?rev=249351&r1=249350&r2=249351&view=diff
==============================================================================
--- llvm/trunk/include/llvm/ProfileData/SampleProfReader.h (original)
+++ llvm/trunk/include/llvm/ProfileData/SampleProfReader.h Mon Oct  5 16:08:05 2015
@@ -224,8 +224,6 @@ protected:
                                  uint64_t Count);
   std::error_code readOneFunctionProfile(const SourceStack &Stack, bool Update);
   std::error_code readFunctionProfiles();
-  std::error_code readModuleGroup();
-  std::error_code readWorkingSet();
   std::error_code skipNextWord();
   template <typename T> ErrorOr<T> readNumber();
   ErrorOr<StringRef> readString();

Modified: llvm/trunk/lib/ProfileData/SampleProfReader.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ProfileData/SampleProfReader.cpp?rev=249351&r1=249350&r2=249351&view=diff
==============================================================================
--- llvm/trunk/lib/ProfileData/SampleProfReader.cpp (original)
+++ llvm/trunk/lib/ProfileData/SampleProfReader.cpp Mon Oct  5 16:08:05 2015
@@ -671,16 +671,6 @@ SampleProfileReaderGCC::readOneFunctionP
   return sampleprof_error::success;
 }
 
-std::error_code SampleProfileReaderGCC::readModuleGroup() {
-  // FIXME(dnovillo) - Module support still not implemented.
-  return sampleprof_error::not_implemented;
-}
-
-std::error_code SampleProfileReaderGCC::readWorkingSet() {
-  // FIXME(dnovillo) - Working sets still not implemented.
-  return sampleprof_error::not_implemented;
-}
-
 /// \brief Read a GCC AutoFDO profile.
 ///
 /// This format is generated by the Linux Perf conversion tool at
@@ -694,18 +684,6 @@ std::error_code SampleProfileReaderGCC::
   if (std::error_code EC = readFunctionProfiles())
     return EC;
 
-// FIXME(dnovillo) - Module groups and working set support are not
-// yet implemented.
-#if 0
-  // Read the module group file.
-  if (std::error_code EC = readModuleGroup())
-    return EC;
-
-  // Read the working set.
-  if (std::error_code EC = readWorkingSet())
-    return EC;
-#endif
-
   return sampleprof_error::success;
 }
 




More information about the llvm-commits mailing list