[PATCH] D13219: [InstCombine] SimplifyDemandedVectorElts wrongly analyzes ConstantVector select masks with ConstantExpr elements (PR24922).

[Sanjay Patel via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

I don't know the answers to the general ConstantExpr questions, but this patch is a strict improvement / correctness fix, so LGTM.
There's a similar check here:
http://llvm.org/docs/doxygen/html/InstructionCombining_8cpp_source.html#l00838

I would add a similar comment in this patch to explain the reason we must distinguish ConstantExpr from Constant.


http://reviews.llvm.org/D13219