[PATCH] D13439: DAGCombiner: Don't stop finding better chain on 2 aliases

[hfinkel@anl.gov via llvm-commits]

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

LGTM.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:14365
@@ -14366,3 +14364,3 @@
     // chain.
-    if (Depth > 6 || Aliases.size() == 2) {
+    if (Depth > 6) {
       Aliases.clear();
----------------
It would be nice, IMHO, to get rid of these hard-coded depth limits and turn them into cl::opts. This is a general comment, as I feel the same way about all of these depth limits everywhere. [I'm not requesting that you change this here].


http://reviews.llvm.org/D13439