[PATCH] D13055: [ELF2] Handle -m option
Denis Protivensky via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 5 06:44:04 PDT 2015
denis-protivensky added a comment.
In http://reviews.llvm.org/D13055#259679, @rafael wrote:
> Just one more nit:
>
> in ELFFileBase::getEMachine() I think you have to keep the
> llvm_unreachable outside of the switch to avoid a gcc warning.
>
> LGTM with that.
It's clang issuing warning because of extending ELFKind enum with ELFNoneKind value, that's why I moved the check. gcc doesn't give warning in either cases.
http://reviews.llvm.org/D13055
More information about the llvm-commits
mailing list