[PATCH] D13055: [ELF2] Handle -m option

Rafael Espíndola via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 5 06:01:25 PDT 2015


Just one more nit:

in ELFFileBase::getEMachine() I think you have to keep the
llvm_unreachable outside of the switch to avoid a gcc warning.

LGTM with that.


On 5 October 2015 at 08:56, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
> See the attached patch for example.
>
> On 5 October 2015 at 08:51, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
>>> Returned back FirstObjName config variable since we need a flag indicating whether ELF parameters were grabbed from the first object file or from the -m option.
>>
>> Why?
>>
>> You report an error as soon as an incompatibility is found. If
>> getFirstELF returns non null, you know either
>>
>> * There was a -m and it is compatible with it
>> * There was no -m and you don't have to worry about it
>>
>> In any case you only have to check if that file is compatible with the
>> current one.
>>
>> Cheers,
>> Rafael


More information about the llvm-commits mailing list