[PATCH] D13107: Support for function summary index bitcode sections and files. Includes bitcode reader/writer support for these sections, and support for creation of combined index files.

[Mehdi AMINI via llvm-commits]

joker.eph added inline comments.

================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:5659
@@ +5658,3 @@
+      llvm::make_unique<FunctionIndexBitcodeReader>(Buf.get(), Context,
+                                                    DiagnosticHandler);
+
----------------
Why not having R as a stack local variable? Initially before the `unique_ptr` I thought you were intended to pass it outside but it seems to be a pure local variable.

================
Comment at: test/Bitcode/thinlto-function-summary.ll:18
@@ +17,3 @@
+; CHECK: define i32 @foo()
+
+; Function Attrs: nounwind uwtable
----------------
I didn't see the second `RUN:` line, forget this.


http://reviews.llvm.org/D13107