[PATCH] D13358: InstCombine: Fold comparisons between unguessable allocas and other pointers

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 2 17:21:38 PDT 2015


hans retitled this revision from "InstSimplify: Fold comparisons between unguessable allocas and other pointers" to "InstCombine: Fold comparisons between unguessable allocas and other pointers".
hans updated the summary for this revision.
hans updated this revision to Diff 36417.
hans added a comment.

Moving this to instcombine.

The previous patch ran into a terrifying bug where instsimplify would get run on IR that wasn't fully constructed yet, which meant it couldn't see all uses of an alloca and folded a bit too aggressively.

This new patch successfully bootstraps Clang. The optimization fires 67 times during bootstrap and reduces Clang binary size with 8519 bytes.


http://reviews.llvm.org/D13358

Files:
  lib/Transforms/InstCombine/InstCombineCompares.cpp
  lib/Transforms/InstCombine/InstCombineInternal.h
  test/Transforms/InstCombine/compare-alloca.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D13358.36417.patch
Type: text/x-patch
Size: 7868 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151003/78b49884/attachment.bin>


More information about the llvm-commits mailing list