[lld] r249093 - [elf2] Ignore --{start,end}-group.

Joerg Sonnenberger via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 2 13:50:37 PDT 2015


On Fri, Oct 02, 2015 at 10:50:42AM -0400, Rafael EspĂ­ndola wrote:
> On 2 October 2015 at 08:42, Joerg Sonnenberger via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > On Thu, Oct 01, 2015 at 10:54:37PM -0000, Michael J. Spencer via llvm-commits wrote:
> >> Author: mspencer
> >> Date: Thu Oct  1 17:54:37 2015
> >> New Revision: 249093
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=249093&view=rev
> >> Log:
> >> [elf2] Ignore --{start,end}-group.
> >
> > Why? This sounds like a pretty dangerous idea?
> 
> Because we are just starting.
> 
> Having a white list of ignored options makes perfect sense at this
> stage in the project.

No, I don't think it does. Building a list of recognized, but ignored
with warning options makes sense. Silently ignoring things that should
affect the output in pretty fundamental ways is not a good idea.

Joerg


More information about the llvm-commits mailing list