[PATCH] D13397: Rename alias definitions by both aliased and alias name

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.


================
Comment at: ELF/Options.td:73
@@ -72,8 +72,3 @@
 def alias_Bstatic_static: Flag<["-"], "static">, Alias<Bstatic>;
-def alias_L : Joined<["--"], "library-path=">, Alias<L>;
-def alias_discard_all: Flag<["-"], "x">, Alias<discard_all>;
-def alias_discard_locals: Flag<["-"], "X">, Alias<discard_locals>;
-def alias_entry : Separate<["-"], "e">, Alias<entry>;
-def alias_l : Joined<["--"], "library=">, Alias<l>;
-def alias_soname : Separate<["-"], "h">, Alias<soname>;
-def alias_snoame : Separate<["-"], "soname">, Alias<soname>;
+def alias_L_library_path : Joined<["--"], "library-path=">, Alias<L>;
+def alias_discard_all_x: Flag<["-"], "x">, Alias<discard_all>;
----------------
I'd name this alias_L__library_path (two extra __ for --).

(in case we want to define two aliases, say -foo and --foo)

================
Comment at: ELF/Options.td:77
@@ +76,3 @@
+def alias_entry_e : Separate<["-"], "e">, Alias<entry>;
+def alias_l_library : Joined<["--"], "library=">, Alias<l>;
+def alias_soname_h : Separate<["-"], "h">, Alias<soname>;
----------------
alias_l__library


http://reviews.llvm.org/D13397