[LNT] r249106 - previous is misleading when using absmin_diff

[Chris Matthews via llvm-commits]

Author: cmatthews
Date: Thu Oct  1 19:02:32 2015
New Revision: 249106

URL: http://llvm.org/viewvc/llvm-project?rev=249106&view=rev
Log:
previous is misleading when using absmin_diff

Modified:
    lnt/trunk/lnt/server/reporting/analysis.py

Modified: lnt/trunk/lnt/server/reporting/analysis.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/reporting/analysis.py?rev=249106&r1=249105&r2=249106&view=diff
==============================================================================
--- lnt/trunk/lnt/server/reporting/analysis.py (original)
+++ lnt/trunk/lnt/server/reporting/analysis.py Thu Oct  1 19:02:32 2015
@@ -57,23 +57,22 @@ class ComparisonResult:
         # if bigger_is_better.
         if aggregation_fn == stats.safe_min and bigger_is_better:
             aggregation_fn = stats.safe_max
-        
+
         if samples:
             self.current = aggregation_fn(samples)
         else:
             self.current = None
-        if prev_samples:
-            self.previous = aggregation_fn(prev_samples)
-        else:
-            self.previous = None
+
+        self.previous = None
 
         # Compute the comparison status for the test value.
         self.delta = 0
         self.pct_delta = 0.0
-        if self.current and self.previous:
+        if self.current and prev_samples:
             self.delta, value = absmin_diff(self.current, prev_samples)
             if value != 0:
                 self.pct_delta = self.delta / value
+            self.previous = value
 
         # If we have multiple values for this run, use that to estimate the
         # distribution.