[PATCH] D13301: [SimplifyLibCalls] Fix instruction misplacement in string/memory libcall optimization

Bruno Cardoso Lopes via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 1 15:08:50 PDT 2015


bruno added inline comments.

================
Comment at: lib/Transforms/Utils/SimplifyLibCalls.cpp:2080
@@ -2078,1 +2079,3 @@
+    // to guarantee we reach all uses we might replace later on.
+    IRBuilder<> TmpBuilder(SimplifiedCI ? SimplifiedCI : CI);
     if (SimplifiedCI && SimplifiedCI->getCalledFunction())
----------------
ab wrote:
> Why not sink this in the block below? That'll eliminate the need for the SimplifiedCI null check.
Doh! I'll include it in the commit. :-)


Repository:
  rL LLVM

http://reviews.llvm.org/D13301





More information about the llvm-commits mailing list