[PATCH] D13347: [FastISel][X86] Teach how to select SSE2/AVX bitcasts between 128/256-bit vector types.

[Quentin Colombet via llvm-commits]

qcolombet added a comment.

Hi Andrea,

Couple of questions, see inline, otherwise looks quite reasonable to me.

Thanks,
-Quentin


================
Comment at: lib/Target/X86/X86FastISel.cpp:3240
@@ +3239,3 @@
+    if (!X86ScalarSSEf64)
+      return false;
+
----------------
Why do we have to check that here?
We are interested in 128 and 256 bit vector types. I do not understand why the fact that f64 may be mapped on x87 need to be considered?

================
Comment at: lib/Target/X86/X86FastISel.cpp:3247
@@ +3246,3 @@
+        SrcVT.getSizeInBits() != DstVT.getSizeInBits())
+      return false;
+
----------------
Could you add test cases for these checks?
In particular the different SizeInBits part.


http://reviews.llvm.org/D13347