[PATCH] D12456: [IR] Add operand bundles to CallInst and InvokeInst.

[Sanjoy Das via llvm-commits]

sanjoy added a comment.

Dmitry Babokin via llvm-commits wrote:
 > dbabokin added a subscriber: dbabokin.
 > dbabokin added a comment.
 >
 > Sanjoy,
 >
 > Your comment in include/llvm/IR/InstrTypes.h in line 1137 is undeniably
 > nice, but it causes a warning (or an error when building with "-Wall"):
 >
 > “error: multi-line comment [-Werror=comment]”
 >
 > Could you please fix it? For example you can use | instead of , or add
 > some "shielding" (|, ///, or whatever you prefer) in the leftmost 
position
 > of the whole pseudo graphics (i.e. lines 1137-1149.

I'm more than happy to fix this, but I'm not able to reproduce this
issue using clang++ on OSX (my default build environment).

Can you please verify that the change below fixes the issue?

diff --git a/include/llvm/IR/InstrTypes.h b/include/llvm/IR/InstrTypes.h
index 70ab973..0c2ff91 100644

- a/include/llvm/IR/InstrTypes.h

+++ b/include/llvm/IR/InstrTypes.h
@@ -1134,19 +1134,19 @@ typedef OperandBundleDefT<const Value *> 
ConstOperandBundleDef;

  ///
  /// The layout of an operand bundle user is
  ///

-///              +-------uint32_t End---------------------------------+
-///             / 
-///            /  +------uint32_t Begin------------------+

  -///           /  / 
    +///          +-----------uint32_t 

End-------------------------------------+
+///          |                                                            |
+///          |  +--------uint32_t Begin--------------------+              |
+///          |  |                                          |              |

  ///          ^  ^                                          v 
     v
  /// 

|------|------|----|----|----|----|----|---------|----|---------|----|-----


  ///  | BOI0 | BOI1 | .. | DU | U0 | U1 | .. | BOI0_U0 | .. | BOI1_U0 | 

.. | Un

  /// 

|------|------|----|----|----|----|----|---------|----|---------|----|-----


  ///   v  v                                  ^              ^

-///                                      /              /
-///       +------uint32_t Begin----------+              /
-///                                                    /
-///       +-------uint32_t End-------------------------+
+///   |  |                                  |              |
+///   |  +--------uint32_t Begin------------+              |
+///   |                                                    |
+///   +-----------uint32_t End-----------------------------+

  ///
  ///
  /// BOI0, BOI1 ... are descriptions of operand bundles in this User's 

use list.

>
 > Thanks!
 >
 > Dmitry.
 >
 >
 > Repository:
 >    http://reviews.llvm.org/diffusion/L/ LLVM
 >
 > http://reviews.llvm.org/D12456
 >
 >
 >
 > _______________________________________________
 > llvm-commits mailing list
 > llvm-commits at lists.llvm.org
 > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


Repository:
  rL LLVM

http://reviews.llvm.org/D12456