[PATCH] D13356: AMDGPU/SI: Remove assert from AMDGPUOpenCLImageTypeLowering pass

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 1 11:28:59 PDT 2015


arsenm added inline comments.

================
Comment at: lib/Target/AMDGPU/AMDGPUOpenCLImageTypeLoweringPass.cpp:100
@@ +99,3 @@
+    // args missing or not in the expected order.
+    if (cast<MDString>(ArgNode->getOperand(0))->getString() !=
+         KernelArgMDNodeNames[i])
----------------
If you're bothering to check this should probably be a checked dyn_cast


http://reviews.llvm.org/D13356





More information about the llvm-commits mailing list