[PATCH] D13238: [ELF2] Add -Bstatic and -Bdynamic command line switches

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: ELF/Driver.cpp:143
@@ -133,1 +142,3 @@
+    default:
+      continue;
     }
----------------
s/continue/break/ because other branches end with break. If only this thing is different, readers must stop here and think about what's the difference of break and continue in this context, which are actually the same.

================
Comment at: test/elf2/libsearch.s:50
@@ +49,3 @@
+// RUN: not lld -flavor gnu2 -o %t3 %t.o -L%T -Bstatic -lls2 2>&1 \
+// RUN:     | FileCheck --check-prefix=NOLIB2 %s
+// NOLIB2: Unable to find library -lls2
----------------
Indentation is two space width in other places, so do the same.

  RUN: not lld ...
  RUN:   | FileCheck ... 


http://reviews.llvm.org/D13238