[PATCH] D13156: Fix performance problem in long-running SectionMemoryManagers

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 1 07:20:47 PDT 2015


I assume you meant that we are applying execute permissions to the read 
only memory and probably shouldn't be?  If so, I tend to agree.  
However, I'd have to study the code much more carefully to understand 
the implications.  There may be an issue with the relocations or something.

Philip

On 09/30/2015 07:49 PM, Keno Fischer wrote:
> loladiro added a comment.
>
> Thanks for the quick review. Also, while looking at this again, I noticed, we're setting RX permissions on RO memory. Does that sound right? Seems like that memory should be executable? Isn't that the whole point of splitting this?
>
>
> Repository:
>    rL LLVM
>
> http://reviews.llvm.org/D13156
>
>
>



More information about the llvm-commits mailing list