[PATCH] D13156: Fix performance problem in long-running SectionMemoryManagers

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 16:55:37 PDT 2015


reames accepted this revision.
reames added a reviewer: reames.
reames added a comment.

LGTM


================
Comment at: lib/ExecutionEngine/SectionMemoryManager.cpp:143
@@ +142,3 @@
+  // having to apply them again.
+  CodeMem.AllocatedMem.append(CodeMem.PendingMem.begin(),CodeMem.PendingMem.end());
+  RODataMem.AllocatedMem.append(RODataMem.PendingMem.begin(),RODataMem.PendingMem.end());
----------------
very minor: I'd put the clear immediately after each append.


http://reviews.llvm.org/D13156





More information about the llvm-commits mailing list