[PATCH] D13316: Visibly fail if attempting to encode register AH, BH, CH, DH in a REX-prefixed instruction.

Douglas Katzman via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 16:33:12 PDT 2015


dougk created this revision.
dougk added reviewers: craig.topper, chandlerc.
dougk added a subscriber: llvm-commits.

Ideally this could be caught in the asm parser, but that would essentially require that the parser ask the emitter if there is a valid encoding.
So the next best thing is to fail in the emitter rather than encode something that is not the instruction the user wrote.

Fixes PR25003

http://reviews.llvm.org/D13316

Files:
  lib/Target/X86/AsmParser/X86AsmParser.cpp
  lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp
  test/MC/X86/encoder-fail.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D13316.36160.patch
Type: text/x-patch
Size: 7148 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150930/e42ef612/attachment.bin>


More information about the llvm-commits mailing list