[PATCH] D13275: [lld][elf2] Sort output sections.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 14:56:03 PDT 2015


> This is a lambda, it has an unutterable type.

Never mind, I read it as return value.

On the other hand, if it is a function it should be a verb (computeRank).

>> It might be more explicit to just list them all.
> Explicitly list them as an error?

Yes, and drop the default.

> There's a testcase that creates a non allocated nobits section. If we don't ignore that, it ends up being placed after the section string table, which then causes an assert because the string table is finalized before the non allocated section's name is added.

This is probably not the place to work around it. Definitely not
without a comment. I will debug it a bit.


More information about the llvm-commits mailing list