[PATCH] D13055: [ELF2] Handle -m option

Rafael Espíndola via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 14:44:55 PDT 2015


You are missing a testcase where -m *is* compatible with the rest of
the elf files :-)

On 30 September 2015 at 17:39, Rafael Ávila de Espíndola
<llvm-commits at lists.llvm.org> wrote:
> rafael added inline comments.
>
> ================
> Comment at: ELF/Config.h:30
> @@ -20,1 +29,3 @@
>  struct Configuration {
> +  bool is64() const {
> +    return ElfKind == ELF64BEKind || ElfKind == ELF64LEKind;
> ----------------
> git-clang-format
>
> ================
> Comment at: ELF/SymbolTable.cpp:26
> @@ -25,4 +25,3 @@
>  bool SymbolTable::shouldUseRela() const {
> -  ELFKind K = getFirstELF()->getELFKind();
> -  return K == ELF64LEKind || K == ELF64BEKind;
> +  return Config->is64();
>  }
> ----------------
> git-clang-format
>
>
> http://reviews.llvm.org/D13055
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list