[polly] r248823 - Replace default destructors by {} destructors

[David Blaikie via llvm-commits]

On Wed, Sep 30, 2015 at 1:47 PM, Tobias Grosser <tobias at grosser.es> wrote:

> On 09/30/2015 09:51 PM, David Blaikie wrote:
>
>> On Tue, Sep 29, 2015 at 11:04 PM, Tobias Grosser <tobias at grosser.es>
>> wrote:
>>
>> On 09/30/2015 12:56 AM, David Blaikie wrote:
>>>
>>> On Tue, Sep 29, 2015 at 3:12 PM, Tobias Grosser <tobias at grosser.es>
>>>> wrote:
>>>>
>>>> On 09/29/2015 10:12 PM, David Blaikie wrote:
>>>>
>>>>>
>>>>> On Tue, Sep 29, 2015 at 12:54 PM, Tobias Grosser via llvm-commits <
>>>>>
>>>>>> llvm-commits at lists.llvm.org> wrote:
>>>>>>
>>>>>> Author: grosser
>>>>>>
>>>>>> Date: Tue Sep 29 14:52:09 2015
>>>>>>> New Revision: 248823
>>>>>>>
>>>>>>> URL: http://llvm.org/viewvc/llvm-project?rev=248823&view=rev
>>>>>>> Log:
>>>>>>> Replace default destructors by {} destructors
>>>>>>>
>>>>>>> Hope this fixes the buildbots for now.
>>>>>>>
>>>>>>>
>>>>>>> Oh, sorry about that. Didn't see those buildbot failures.
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>> No worries. This was a rather quick fix, so it is not minimal as you
>>>>> noted below. However, I already was surprised that your original
>>>>> change caused compilation failures, but onlyon older gcc versions.
>>>>> In case you happen to understand the error message, would it make
>>>>> sense to move back to a fixed version of your change?
>>>>>
>>>>>
>>>>
>>>> Do you have a link (or just copy/paste inline) to the buildbot failure?
>>>> I
>>>> didn't spot it in any of the emails I got.
>>>>
>>>>
>>> I added it in one of my previous commits that tried to unbreak the bot:
>>>
>>>      BlockGenerators.h:683:7: error: looser throw specifier for ‘virtual
>>>      polly::RegionGenerator::~RegionGenerator()’
>>>      BlockGenerators.h:164:11: error:   overriding ‘virtual
>>> polly::BlockGenerator::~BlockGenerator() noexcept
>>>      (true)`
>>>
>>
>>
>> Ah, did this fail after 248765 or only before? I removed the derived dtor
>> (since it was unnecessary) in an attempt to fix this error. Sorry,
>> should've called that out in my commit message and in a follow up to
>> r248764.
>>
>
> This failed after 248764:
>
> http://lab.llvm.org:8011/builders/polly-amd64-linux/builds/34576
>
> and remained broken with 248765:
>
> http://lab.llvm.org:8011/builders/polly-amd64-linux/builds/34577


Hmm - beats me then...

- Dave


>
>
> Best,
> Tobias
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150930/9ee1df70/attachment.html>