[PATCH] D13055: [ELF2] Handle -m option

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 10:53:34 PDT 2015


ruiu added inline comments.

================
Comment at: ELF/Driver.cpp:65-67
@@ +64,5 @@
+  if (ElfKind != Config->ElfKind || EMachine != Config->EMachine)
+    error(Twine(MB.getBufferIdentifier() + " is incompatible with " +
+                (Config->FirstObjName.empty() ? "target architecture"
+                                              : Config->FirstObjName)));
+  return std::move(File);
----------------
I think you can remove Twine() from this statement. Twine is to concatenate strings, so at least grouping an entire string with Twine() doesn't make sense.


http://reviews.llvm.org/D13055





More information about the llvm-commits mailing list