[PATCH] D13250: Extend known bits to understand @llvm.bswap

[Sanjay Patel via llvm-commits]

spatel accepted this revision.
This revision is now accepted and ready to land.

================
Comment at: test/Transforms/InstCombine/bswap-known-bits.ll:3
@@ +2,3 @@
+; Note: This is testing functionality in computeKnownBits.  I'd have rather
+; used instsimplify, but the bit test folding is aparently only in instcombine.
+
----------------
Interesting...I didn't consider -instsimplify for the similar tests in D13222. I will look again.

Typo: "apparently"

================
Comment at: test/Transforms/InstCombine/bswap-known-bits.ll:28
@@ +27,3 @@
+
+define i1 @test3(i16 %arg) {
+; CHECK-LABEL: @test3
----------------
Do we need this test? Seems like test4 is a superset.
Use different bswap sizes for more test coverage?


http://reviews.llvm.org/D13250