[PATCH] D13286: [ELF2] Add --[no-]whole-archive command line switches

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 09:13:33 PDT 2015


grimar added a subscriber: grimar.

================
Comment at: ELF/Driver.cpp:147
@@ -151,1 +146,3 @@
+      break;
+    }
   }
----------------
There is no default section. Not sure is is necessarily to use though since I guess warning about that is turned off in most cases.

================
Comment at: ELF/InputFiles.cpp:210
@@ +209,3 @@
+  assert(nullptr != File && "File isn't opened, call parse() first");
+
+  // Allocate a buffer for Lazy objects.
----------------
Looks like that assert should be at first line. Also that would be consistent with ArchiveFile::getMembers() 


http://reviews.llvm.org/D13286





More information about the llvm-commits mailing list