[PATCH] D11885: AMDGPU/SI: Add SI Machine Scheduler

[Axel Davy via llvm-commits]

axeldavy added inline comments.

================
Comment at: lib/Target/AMDGPU/SIMachineScheduler.cpp:217
@@ +216,3 @@
+
+  if (Cand.SGPRUsage > 60 &&
+      tryLess(TryCand.SGPRUsage, Cand.SGPRUsage, TryCand, Cand, RegUsage))
----------------
arsenm wrote:
> This shouldn't be hardcoded. A pass parameter or command line option read during pass initialization
I think this hardcoded value is suboptimal (as any hardcoded value would be) and that
the length of the block and other stuffs should be taken into account for that heuristic.

I don't think it makes sense to ask user to set this value.

I suggest to keep that hardcoded value for now, and replace that heuristic when we find a better one.



http://reviews.llvm.org/D11885