[PATCH] D13281: Add missing test for build attribute Tag_Advanced_SIMD_arch when targeting v8.1

Alexandros Lamprineas via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 02:16:58 PDT 2015


labrinea created this revision.
labrinea added reviewers: rengolin, llvm-commits.
Herald added a subscriber: aemerson.

Missing test case for ARM AttributeParser.

http://reviews.llvm.org/D13281

Files:
  test/tools/llvm-readobj/ARM/attribute-4.s
  tools/llvm-readobj/ARMAttributeParser.cpp

Index: tools/llvm-readobj/ARMAttributeParser.cpp
===================================================================
--- tools/llvm-readobj/ARMAttributeParser.cpp
+++ tools/llvm-readobj/ARMAttributeParser.cpp
@@ -193,7 +193,7 @@
 void ARMAttributeParser::Advanced_SIMD_arch(AttrType Tag, const uint8_t *Data,
                                             uint32_t &Offset) {
   static const char *Strings[] = {
-    "Not Permitted", "NEONv1", "NEONv2+FMA", "ARMv8-a NEON"
+    "Not Permitted", "NEONv1", "NEONv2+FMA", "ARMv8-a NEON", "ARMv8.1-a NEON"
   };
 
   uint64_t Value = ParseInteger(Data, Offset);
Index: test/tools/llvm-readobj/ARM/attribute-4.s
===================================================================
--- test/tools/llvm-readobj/ARM/attribute-4.s
+++ test/tools/llvm-readobj/ARM/attribute-4.s
@@ -15,6 +15,13 @@
 @CHECK-OBJ-NEXT: TagName: FP_arch
 @CHECK-OBJ-NEXT: Description: VFPv3-D16
 
+.eabi_attribute  Tag_Advanced_SIMD_arch, 4
+ at CHECK:   .eabi_attribute 12, 4
+ at CHECK-OBJ: Tag: 12
+ at CHECK-OBJ-NEXT: Value: 4
+ at CHECK-OBJ-NEXT: TagName: Advanced_SIMD_arch
+ at CHECK-OBJ-NEXT: Description: ARMv8.1-a NEON
+
 .eabi_attribute  Tag_PCS_config, 4
 @CHECK:   .eabi_attribute 13, 4
 @CHECK-OBJ: Tag: 13


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D13281.36076.patch
Type: text/x-patch
Size: 1221 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150930/c8d7fb92/attachment.bin>


More information about the llvm-commits mailing list