[polly] r248823 - Replace default destructors by {} destructors

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 29 15:56:01 PDT 2015


On Tue, Sep 29, 2015 at 3:12 PM, Tobias Grosser <tobias at grosser.es> wrote:

> On 09/29/2015 10:12 PM, David Blaikie wrote:
>
>> On Tue, Sep 29, 2015 at 12:54 PM, Tobias Grosser via llvm-commits <
>> llvm-commits at lists.llvm.org> wrote:
>>
>> Author: grosser
>>> Date: Tue Sep 29 14:52:09 2015
>>> New Revision: 248823
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=248823&view=rev
>>> Log:
>>> Replace default destructors by {} destructors
>>>
>>> Hope this fixes the buildbots for now.
>>>
>>>
>> Oh, sorry about that. Didn't see those buildbot failures.
>>
>
> No worries. This was a rather quick fix, so it is not minimal as you
> noted below. However, I already was surprised that your original
> change caused compilation failures, but onlyon older gcc versions.
> In case you happen to understand the error message, would it make
> sense to move back to a fixed version of your change?


Do you have a link (or just copy/paste inline) to the buildbot failure? I
didn't spot it in any of the emails I got.

Oh, wait, was this the throws-spec problem? I /thought/ I fixed that by
making the derived dtor '= default' too, but maybe that was insufficient?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150929/93eea11a/attachment.html>


More information about the llvm-commits mailing list