[PATCH] D12681: Calling conventions for HHVM

[Maksim Panchenko via llvm-commits]

maksfb added a comment.

Thanks!


================
Comment at: include/llvm/Target/TargetFrameLowering.h:99
@@ -98,1 +98,3 @@
 
+  /// getStackAlignmentSkew - return the skew that has to be applied to stack
+  /// alignment under certain conditions (e.g. stack was adjusted before
----------------
qcolombet wrote:
> Do not repeat the method name. This was the old style comment.
Ok.

================
Comment at: include/llvm/Target/TargetFrameLowering.h:102
@@ +101,3 @@
+  /// function \p Fn was called).
+  unsigned getStackAlignmentSkew(const MachineFunction &MF) const;
+
----------------
qcolombet wrote:
> Should be virtual.
Ok.

================
Comment at: lib/CodeGen/TargetFrameLoweringImpl.cpp:91
@@ +90,3 @@
+  if (LLVM_UNLIKELY(MF.getFunction()->getCallingConv() == CallingConv::HHVM))
+    return MF.getTarget().getPointerSize();
+
----------------
qcolombet wrote:
> Is HHVM a generic calling convention or is it x86_64 specific.
> 
> If the latter, move this code in a x86 frame lowering override.
It is a generic calling convention and for other architectures we will also have a return address removed from the stack before we enter the function.


http://reviews.llvm.org/D12681