[PATCH] D12958: Refactor computeKnownBits alignment handling code
    Philip Reames via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Sep 29 08:07:38 PDT 2015
    
    
  
reames added a comment.
Much, much clearer.  LGTM
================
Comment at: lib/Analysis/ValueTracking.cpp:1516
@@ +1515,3 @@
+  // Aligned pointers have trailing zeros - refine KnownZero set
+  unsigned Align = getAlignment(V);
+  if (Align)
----------------
I might put this inside a check for pointer type, but it's already handled by the called code and would only be a minor improvement on a much larger improvement.  
http://reviews.llvm.org/D12958
    
    
More information about the llvm-commits
mailing list