[PATCH] D13218: Mark BB as annotated if its weight is > 0

Diego Novillo via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 29 06:51:01 PDT 2015


dnovillo added a comment.

Let me back up a little bit.  If getBlockWeight() marks the block visited all the time, then how can propagation work?  getBlockWeight is only used when computing the *initial* weight of the blocks (I agree with David, it should be renamed to setBlockWeight()).

But, in looking at the code again, it doesn't seem correct to mark the block visited there.  We mark them visited when we are assigning equivalence classes.

I think I'm missing something here.


http://reviews.llvm.org/D13218





More information about the llvm-commits mailing list