[PATCH] D13220: Optimize DeadCodeEliminationPass

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 29 05:57:27 PDT 2015


reames added inline comments.

================
Comment at: lib/Transforms/Scalar/DCE.cpp:136
@@ +135,3 @@
+  // the worklist with the entire function's worth of instructions.
+  for (inst_iterator FI = inst_begin(F), FE = inst_end(F); FI != FE;) {
+    Instruction *I = &*FI;
----------------
sanjoy wrote:
> Can you use `inst_range` here?
I'd prefer you didn't use inst_range here since the iterator update is somewhat subtle and inst_range might hide that.


Repository:
  rL LLVM

http://reviews.llvm.org/D13220





More information about the llvm-commits mailing list