[PATCH] D13235: [mips][microMIPS] Fix an issue with selecting sqrt instruction

[Zlatko Buljan via llvm-commits]

zbuljan created this revision.
zbuljan added reviewers: dsanders, zoran.jovanovic, hvarga.
zbuljan added subscribers: petarj, llvm-commits.

This patch fixes bug 2206 (https://dmz-portal.mips.com/bugz/show_bug.cgi?id=2206).

http://reviews.llvm.org/D13235

Files:
  lib/Target/Mips/MipsInstrFPU.td
  test/CodeGen/Mips/sqrt.ll

Index: test/CodeGen/Mips/sqrt.ll
===================================================================
--- /dev/null
+++ test/CodeGen/Mips/sqrt.ll
@@ -0,0 +1,12 @@
+; RUN: llc  < %s -march=mipsel -mcpu=mips32r2 -mattr=+micromips | FileCheck %s
+; RUN: llc  < %s -march=mips -mcpu=mips32r2 -mattr=+micromips | FileCheck %s
+
+define float @sqrt_fn(float %value) #0 {
+entry:
+  %sqrtf = tail call float @sqrtf(float %value) #0
+  ret float %sqrtf
+}
+
+declare float @sqrtf(float)
+
+; CHECK: sqrt
Index: lib/Target/Mips/MipsInstrFPU.td
===================================================================
--- lib/Target/Mips/MipsInstrFPU.td
+++ lib/Target/Mips/MipsInstrFPU.td
@@ -353,11 +353,8 @@
 defm FABS : ABSS_M<"abs.d", II_ABS, fabs>, ABSS_FM<0x5, 17>;
 defm FNEG : ABSS_M<"neg.d", II_NEG, fneg>, ABSS_FM<0x7, 17>;
 
-let AdditionalPredicates = [NotInMicroMips] in {
-def FSQRT_S : MMRel, ABSS_FT<"sqrt.s", FGR32Opnd, FGR32Opnd, II_SQRT_S, fsqrt>,
-              ABSS_FM<0x4, 16>, ISA_MIPS2;
-}
-
+def FSQRT_S : MMRel, StdMMR6Rel, ABSS_FT<"sqrt.s", FGR32Opnd, FGR32Opnd,
+              II_SQRT_S, fsqrt>, ABSS_FM<0x4, 16>, ISA_MIPS2;
 defm FSQRT : ABSS_M<"sqrt.d", II_SQRT_D, fsqrt>, ABSS_FM<0x4, 17>, ISA_MIPS2;
 
 // The odd-numbered registers are only referenced when doing loads,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D13235.35944.patch
Type: text/x-patch
Size: 1288 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150929/6cd37ce4/attachment.bin>