[PATCH] D13132: [X86] Emit .cfi_escape GNU_ARGS_SIZE when adjusting the stack before calls

[Michael Kuperstein via llvm-commits]

mkuper added a comment.

Thanks, David!


================
Comment at: lib/MC/MCAsmStreamer.cpp:1023
@@ +1022,3 @@
+  OS << "\t.cfi_escape ";
+  if (Values.size()) {
+    size_t e = Values.size() - 1;
----------------
majnemer wrote:
> `!Values.empty()`
Right, thanks!

================
Comment at: lib/Target/X86/X86FrameLowering.cpp:2074
@@ +2073,3 @@
+        MF.getInfo<X86MachineFunctionInfo>()->getHasPushSequences()) {
+      const uint8_t GNU_ARGS_SIZE = 0x2e;
+      uint8_t Buffer[9] = { GNU_ARGS_SIZE };
----------------
majnemer wrote:
> Why not use `DW_CFA_GNU_args_size` ?
No good reason, only noticed it exists after I uploaded the patch.


http://reviews.llvm.org/D13132