[PATCH] D13227: [ELF2] Add initial MIPS support

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 28 15:18:52 PDT 2015


ruiu added inline comments.

================
Comment at: ELF/SymbolTable.cpp:50-51
@@ -49,2 +49,4 @@
     return new ARMTargetInfo();
+  case EM_MIPS:
+    return new MipsTargetInfo();
   case EM_PPC:
----------------
atanasyan wrote:
> ruiu wrote:
> > These cases need to be sorted by ASCIIbetical order, but yeah, that should be done in a different patch.
> The case labels are sorted already. Do you want to sort them by xxxTargetInfo class names?
Ah, I didn't notice that. We are using different names for valid reasons (386TargetInfo is not even a valid name!) Thank you for pointing that out.


Repository:
  rL LLVM

http://reviews.llvm.org/D13227





More information about the llvm-commits mailing list