[llvm] r248746 - add a FIXME for a CPU model check that should have an attribute instead

[Sanjay Patel via llvm-commits]

Author: spatel
Date: Mon Sep 28 17:00:24 2015
New Revision: 248746

URL: http://llvm.org/viewvc/llvm-project?rev=248746&view=rev
Log:
add a FIXME for a CPU model check that should have an attribute instead

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=248746&r1=248745&r2=248746&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Mon Sep 28 17:00:24 2015
@@ -1785,7 +1785,8 @@ X86TargetLowering::X86TargetLowering(con
   MaxStoresPerMemmoveOptSize = 4;
   setPrefLoopAlignment(4); // 2^4 bytes.
 
-  // Predictable cmov don't hurt on atom because it's in-order.
+  // A predictable cmov does not hurt on an in-order CPU.
+  // FIXME: Use a CPU attribute to trigger this, not a CPU model.
   PredictableSelectIsExpensive = !Subtarget->isAtom();
   EnableExtLdPromotion = true;
   setPrefFunctionAlignment(4); // 2^4 bytes.