[PATCH] D13227: [ELF2] Add initial MIPS support

[Davide Italiano via llvm-commits]

davide added a subscriber: davide.
davide added a comment.

This seems correct. Minor comments below.


================
Comment at: ELF/Target.h:25
@@ -22,2 +24,3 @@
   unsigned getGotReloc() const { return GotReloc; }
+  llvm::StringRef getDefEntryName() const { return DefEntryName; }
   virtual void writePltEntry(uint8_t *Buf, uint64_t GotEntryAddr,
----------------
Can we keep the getter sorted?

================
Comment at: test/elf2/basic-mips.s:5
@@ +4,3 @@
+# RUN:   | FileCheck %s
+
+# REQUIRES: mips
----------------
Extra \n

================
Comment at: test/elf2/basic-mips.s:8
@@ +7,3 @@
+
+.globl __start;
+__start:
----------------
Can you please add a comment explaining what this test does (as we do on other archs)?


Repository:
  rL LLVM

http://reviews.llvm.org/D13227