[PATCH] D13215: [CMake] Make the bindir and libdir arguments to set_output_directory optional

[Chris Bieneman via llvm-commits]

beanz added inline comments.

================
Comment at: cmake/modules/AddLLVM.cmake:206
@@ -197,1 +205,3 @@
+  set(bindir ${ARGV1})
+  set(libdir ${ARGV2})
   # Do nothing if *_OUTPUT_INTDIR is empty.
----------------
I think that a better way to do this would be to use `cmake_parse_arguments` and make output and bind directory be single value options. Then if one isn't specified it is ignored.

I also think it would be cleaner if set_target_properties were only called if the corresponding value is set.


Repository:
  rL LLVM

http://reviews.llvm.org/D13215