[PATCH] D13005: [Debug] Look through bitcasts to find argument registers

[David Blaikie via llvm-commits]

dblaikie added a subscriber: dblaikie.
dblaikie added a comment.

Looks plausible, but I haven't done much with the debug info location side of things - wouldn't mind a second opinion.


================
Comment at: test/DebugInfo/ARM/float-args.ll:3
@@ +2,3 @@
+; RUN: llvm-dwarfdump -debug-dump=info %t.o | FileCheck %s
+; RUN: %llc_dwarf -filetype=obj -o %t.o -mattr=-vfp2 -float-abi=soft %s
+; RUN: llvm-dwarfdump -debug-dump=info %t.o | FileCheck %s
----------------
Usually I run the llc and dwarfdump commands together, rather than using a temp file:

  llc -o - | llvm-dwarfdump - | FileCheck

(plus all the other usual args)

================
Comment at: test/DebugInfo/ARM/float-args.ll:9
@@ +8,3 @@
+; float foo(float p) {
+;   return p + 1;
+; }
----------------
Do you need a use of 'p' for this test case, or just the argument 'p'? (do you need the arithmetic - or can you just "return p" (or sometimes I'll use a stub-function to ensure a use:

  void f1(float);
  void f2(float p) {
    f1(p);
  }

to make it clear that a use is necessary (& the call can't be optimized away) but it doesn't really matter what that use is))


Repository:
  rL LLVM

http://reviews.llvm.org/D13005