[PATCH] D12992: invariant.group handling in GVN

Piotr Padlewski via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 27 21:47:41 PDT 2015


Prazek marked 6 inline comments as done.

================
Comment at: lib/Analysis/MemoryDependenceAnalysis.cpp:403
@@ +402,3 @@
+    return MemDepResult::getUnknown();
+
+  auto *InvariantGroupMD = LI->getMetadata(LLVMContext::MD_invariant_group);
----------------
dberlin wrote:
> Well, it's safe, if you verify the use is in LI->getParent()->getParent(), no?
> 
Yes, but nobody guarantee that uses list won't change when I will iterate over it.


http://reviews.llvm.org/D12992





More information about the llvm-commits mailing list