[PATCH] D13088: [InlineCost] Adjust inlining cost for implicit null checks

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 27 15:12:22 PDT 2015

sanjoy added a subscriber: sanjoy.
sanjoy added a comment.

I've mentioned this to Chen in person, but I'll repeat what I said:

I'm not sure I understand what the "cost" in this context is supposed
to model.  If it is supposed to model code size then this change makes
sense completely.  If it is supposed to model *compile time* then this
change is not in the right direction -- the implicit null checks stay
explicit throughout optimization, so they will extract the compile
time cost of a "normal" compare and branch.


More information about the llvm-commits mailing list