[PATCH] D13012: [X86] Add XSAVE intrinsics (LLVM part)

Michael Kuperstein via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 27 00:04:48 PDT 2015


mkuper added inline comments.

================
Comment at: lib/Support/Host.cpp:827
@@ +826,3 @@
+
+  //FIXME: Should these feature be conditional on "xsave" feature?
+  Features["xsaveopt"] = Features["xsave"] && HasLeafd && ((ECX >> 0) & 1);
----------------
I think this is fine.

================
Comment at: test/CodeGen/X86/system-intrinsics-64.ll:38
@@ +37,3 @@
+; CHECK-LABEL: test_xsave
+; CHECK: xsave
+  call void @llvm.x86.xsave(i8* %ptr, i32 %hi, i32 %lo)
----------------
Could you please add (in at least one of the tests) a check that the right things get copied into EAX and EDX?


Repository:
  rL LLVM

http://reviews.llvm.org/D13012





More information about the llvm-commits mailing list