[PATCH] D13194: [Polly] Identify and hoist definitively invariant loads
Johannes Doerfert via llvm-commits
llvm-commits at lists.llvm.org
Sat Sep 26 14:25:31 PDT 2015
jdoerfert added a comment.
Some comments to indicate things I will address.
================
Comment at: include/polly/ScopInfo.h:875
@@ +874,3 @@
+ /// Note that scalar accesses that are caused by @p MA will be eliminated in
+ /// the whole SCoP.
+ void hoistMemoryAccess(MemoryAccess &MA, MemoryAccessList &TargetList);
----------------
replace "the whole SCoP." by "this statement."
================
Comment at: include/polly/ScopInfo.h:1151
@@ -1135,1 +1150,3 @@
+ /// @brief TODO
+ void simplifySCoP();
----------------
Will add something here.
================
Comment at: include/polly/ScopInfo.h:1156
@@ +1155,3 @@
+ ///
+ /// During SCoP detection loads can be tagged as "required invariant". In such
+ /// a case we need to verify here that we actually tagged them as invariant,
----------------
This should be only in the next commit, the same for the "required ones" part in the brief desc.
================
Comment at: lib/Analysis/ScopInfo.cpp:2297
@@ +2296,3 @@
+ // them to be treated as parameters (e.g., in conditions) and our code
+ // generation would otherwise use the old value.
+
----------------
This is only needed for the next patch. D13195
================
Comment at: lib/CodeGen/BlockGenerators.cpp:1
@@ -1,2 +1,2 @@
-//===--- BlockGenerators.cpp - Generate code for statements -----*- C++ -*-===//
+
//
----------------
My bad.
================
Comment at: lib/CodeGen/IslNodeBuilder.cpp:822
@@ +821,3 @@
+ isl_set *AccessRange = isl_map_range(MA.getAccessRelation());
+ isl_set_dump(AccessRange);
+ isl_pw_multi_aff *PWAccRel = isl_pw_multi_aff_from_set(AccessRange);
----------------
left over.
http://reviews.llvm.org/D13194
More information about the llvm-commits
mailing list