[PATCH] D13152: [EH] Create removeUnwindEdge utility

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 26 09:30:49 PDT 2015


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

Thanks for the refactor!


================
Comment at: lib/Transforms/Utils/Local.cpp:1266
@@ +1265,3 @@
+    changeToCall(II);
+  } else if (auto *CRI = dyn_cast<CleanupReturnInst>(TI)) {
+    auto *NewCRI =
----------------
I think each if here can be something like:
  NewTI = ...::Create(...);
  OldPad = ...->getUnwindDest();

And then you can share the name taking and edge erasing code for all the non-call terminators.


http://reviews.llvm.org/D13152





More information about the llvm-commits mailing list