[PATCH] D13150: Ignore dbg intrinsics in loop-reroll

hfinkel@anl.gov via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 25 16:21:20 PDT 2015

hfinkel added a comment.

Please upload this patch with full context (http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface).

Comment at: lib/Transforms/Scalar/LoopRerollPass.cpp:1007
@@ +1006,3 @@
+    case llvm::Intrinsic::lifetime_start:
+    case llvm::Intrinsic::lifetime_end:
+      return true;
Why these and not others? I suspect that we could get:

    case Intrinsic::annotation:
    case Intrinsic::ptr_annotation:
    case Intrinsic::var_annotation:

and also:

    case Intrinsic::invariant_start:
    case Intrinsic::invariant_end:
    case Intrinsic::lifetime_start:
    case Intrinsic::lifetime_end:

but for these, at least, we'll need test cases because getting them wrong will miscompile code, and also, they're normally associated with bitcasts to get the pointer type right and you'd need to deal with those too.


More information about the llvm-commits mailing list