[PATCH] D12853: Introduce !value.align metadata for load instruction

hfinkel@anl.gov via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 25 15:00:56 PDT 2015

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

This LGTM; I agree this is a common case and worth representing using metadata instead of calls to @llvm.assume (just as with !nonnull). However, as with !nonnull, if we add this metadata, the associated follow-up work needs to be done:

1. Add code that canonicalizes @llvm.assume calls to this metadata when possible.
2. Audit all places where we combine and/or drop metadata on loads, and preserve / combine this metadata when possible.

If you'll do those things as follow-up, then go ahead.


More information about the llvm-commits mailing list