[PATCH] D13135: [ELF2] Add support for -L and -l command line switches

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 25 12:01:28 PDT 2015

ruiu accepted this revision.
ruiu added a reviewer: ruiu.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with this nit. Hold on for a while for other reviewers. Thanks!

Comment at: ELF/Driver.cpp:70
@@ +69,3 @@
+  } else {
+    Names.reserve(2);
+    Names.push_back((Twine("lib") + Path + ".so").str());
Please do not try to optimize unless proved to be necessary. I'm pretty sure that this is marginal or even slightly negative.


More information about the llvm-commits mailing list