[PATCH] D12937: [ARM] Handle +t2dsp feature as an ArchExtKind in ARMTargetParser.def

A. Skrobov via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 25 05:57:06 PDT 2015

tyomitch added inline comments.

Comment at: include/llvm/Support/ARMTargetParser.def:76
@@ -75,3 +75,3 @@
 ARM_ARCH("armv6zk", AK_ARMV6ZK, "6ZK", "v6zk", ARMBuildAttrs::CPUArch::v6KZ,
-          AEK_SEC)
+          AEK_DSP)
 ARM_ARCH("armv6-m", AK_ARMV6M, "6-M", "v6m", ARMBuildAttrs::CPUArch::v6_M,
richard.barton.arm wrote:
> Are these two lines right? The Z part of ARMv6Z means security, so I think the value should be (AEK_SEC | AEK_DSP) no?
You're certainly right; but these two AEK_SEC were, in fact, no-ops: in the only place where LLVM checks for AEK_SEC, it also checks for Feature_HasV7, accompanied with a "// FIXME: Also available in ARMv6-K"

I'm tempted to leave this as is now, given that reinstating the AEK_SEC would be a NFC with no obvious gain.


More information about the llvm-commits mailing list